Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces should not include EVM Call's made while executing precompile logic #2078

Open
eelanagaraj opened this issue May 2, 2023 · 0 comments

Comments

@eelanagaraj
Copy link
Contributor

eelanagaraj commented May 2, 2023

In general, we want traces to ignore EVM CALL's made by the client during the course of execution (i.e. when looking up an address in the registry, as happens while making a transfer via the precompile). We can most likely do this by turning Debug mode off (as is currently done in TobinTransfer logic), but doing this in the SharedEVMRunner instead, which is only used for executing calls made by the client and shouldn't be traced.

Additionally as part of the ticket, update the e2e tests:

  • TestCallTraceTransactionPrecompileTransfer -- the traces should change
  • add stricter checking to the TestTraceSendCeloViaGoldToken test (and remove associated TODO with this issue)
This was referenced May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant