Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do priceHeap and multiCurrencyPriceHeap need synchronisation protection #1905

Open
piersy opened this issue May 27, 2022 · 0 comments
Open

Do priceHeap and multiCurrencyPriceHeap need synchronisation protection #1905

piersy opened this issue May 27, 2022 · 0 comments
Labels
good first issue

Comments

@piersy
Copy link
Contributor

piersy commented May 27, 2022

Description

This upstream pr 067084f fixed some race conditions in the txpool but it strangely seems to have left out synchronising over the price heaps.

we should investigate and see if they do need extra protection.
@carterqw2 carterqw2 added triage Issue needs triaging and removed blockchain labels Feb 9, 2023
@carterqw2 carterqw2 added good first issue and removed triage Issue needs triaging labels Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piersy @carterqw2 and others