Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: drop usage of minio/blake2b in favour of native /x/crypto implementation #908

Closed
Wondertan opened this issue Jul 13, 2022 · 0 comments · Fixed by #927
Closed

deps: drop usage of minio/blake2b in favour of native /x/crypto implementation #908

Wondertan opened this issue Jul 13, 2022 · 0 comments · Fixed by #927
Labels
good first issue Good for newcomers

Comments

@Wondertan
Copy link
Member

We can follow the multihash example here. which states the Go's implementation of blake is no faster and drop the dependency.

The task would be to find all the usages(I can think of one only right now in header/p2p/subscriber) and swap with native Go's one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: replacing blake2b implementation with native /x/crypto distractedm1nd/celestia-node
1 participant
@Wondertan