Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: async blob submissions #3296

Open
Bidon15 opened this issue Apr 4, 2024 · 3 comments · Fixed by #3298
Open

[Feature Request]: async blob submissions #3296

Bidon15 opened this issue Apr 4, 2024 · 3 comments · Fixed by #3298
Assignees
@cmwaters
Labels
area:api Related to celestia-node API area:blob enhancement New feature or request external Issues created by non node team members priority:high High priority issue to be prioritized for the current/following sprint

Comments

@Bidon15
Copy link
Member

Bidon15 commented Apr 4, 2024 •
edited

Implementation ideas

the api should have a way to let users submit async blob submission calls
should be delivered in tandem with #3164

ref: #3256
@Bidon15 Bidon15 added enhancement New feature or request area:api Related to celestia-node API area:blob priority:high High priority issue to be prioritized for the current/following sprint labels Apr 4, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Apr 4, 2024
@cmwaters cmwaters self-assigned this Apr 5, 2024
@cmwaters cmwaters mentioned this issue Apr 5, 2024
Merged
@0xRampey
Copy link

Any plans to return result statuses through a channel on async blob submission? Like INCLUDED, FINALIZED, CANCELLED etc

@renaynay
Copy link
Member

@0xRampey yes something like that, we are considering adding an endpoint to blob module that would be able to submit a tx and query for its status, returning the result through a channel once included.

renaynay added a commit that referenced this issue Apr 18, 2024
@cmwaters @renaynay
feat(state): Integrate new Signer for concurrent tx submission (#3298)
6382dc1 
Closes: #3296

This adds the
[`Signer`](https://github.com/celestiaorg/celestia-app/blob/bcab06582c9802f1d49a2bee86820792258bb587/pkg/user/signer.go#L31)
struct from celestia-app's user package.

Signer keeps track of both the network and local sequence number
allowing for multiple messages to be signed within a single block.

This also uses the `EstimateGas` function of the signer to estimate the
gas, when the user provides 0 as the `gasLim`

TODO: we should probably introduce some gas multiplier (default: 1.1) to
the `EstimateGas` as it seems to underestimate the value (cc @vgonkivs)

---------

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
@Wondertan
Copy link
Member

The current Signer integration doesn't make blob submission async. Yes, it changed the tx submission mode from Block to Sync, but this line makes it equivalent to what we had before

@Wondertan Wondertan reopened this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
area:api Related to celestia-node API area:blob enhancement New feature or request external Issues created by non node team members priority:high High priority issue to be prioritized for the current/following sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(state): Integrate new Signer for concurrent tx submission cmwaters/celestia-node
5 participants
@Bidon15 @0xRampey @Wondertan @cmwaters @renaynay