Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(share/befp): improve logging in case of good errors #2492

Open
vgonkivs opened this issue Jul 17, 2023 · 3 comments · May be fixed by #3176
Open

misc(share/befp): improve logging in case of good errors #2492

vgonkivs opened this issue Jul 17, 2023 · 3 comments · May be fixed by #3176
Labels
area:fraud good first issue Good for newcomers

Comments

@vgonkivs
Copy link
Member

We should make more informative logs about good issues during BEFP verification so as not to confuse users. There are 4 cases where we can conclude the BEFP is valid but can't finish verification(#1, #2, #3, #4). In these case we've verified shares but we can't finish BEFP verification, so we can conclude that BEFP is valid.
@ptdatta
Copy link

ptdatta commented Feb 9, 2024

Hey @vgonkivs Can I work on it?

@vgonkivs
Copy link
Member Author

vgonkivs commented Feb 9, 2024

Yes, thank you 🙏

@ptdatta ptdatta linked a pull request Feb 10, 2024 that will close this issue
Open
@ptdatta
Copy link

ptdatta commented Feb 10, 2024

@vgonkivs please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:fraud good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

misc(share/befp): improve logging in case of good errors ptdatta/celestia-node
2 participants
@vgonkivs @ptdatta