Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and document return value of basic_consume #241

Open
matusvalo opened this issue Jan 14, 2019 · 0 comments
Open

Fix and document return value of basic_consume #241

matusvalo opened this issue Jan 14, 2019 · 0 comments

Comments

@matusvalo
Copy link
Member

Channel.basic_consume() now has 2 return values:

  • consumer_tag - when nowait == False
  • promise object wen nowait == True
  • ValueError() when nowait == True and user does not specify consumer_tag

This is confusing since the API is schizophrenic and returns two different values. Moreover promise object does not have any value to user of library.

I propose that consumer_tag is always returned except the case when ValueError() is raised

Also the return values are not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant