Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian language support #255

Merged
merged 5 commits into from Nov 12, 2021
Merged

Russian language support #255

merged 5 commits into from Nov 12, 2021

Conversation

ildarworld
Copy link
Contributor

Russian locale file is added

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need another russ speaking person to double check. can you tag someone you know

@ildarworld
Copy link
Contributor Author

will need another russ speaking person to double check. can you tag someone you know

Guys, could you be so kind and help with double check the PR for Russian language support for django-celery-results?
@f213
@alexey-goloburdin

Copy link

@neoromantique neoromantique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Native Russian Speaker)

Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
locale/ru/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
ildarworld and others added 3 commits November 12, 2021 12:26
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
Co-authored-by: Stepan Rakitin <stepanr@mailbox.org>
@auvipy auvipy merged commit fe76387 into celery:master Nov 12, 2021

#: django_celery_results/models.py:68 django_celery_results/models.py:176
msgid "Created DateTime"
msgstr "ДатаВремя создания"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think «Дата и время» would be more russian then «ДатаВремя»

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all proposed changes

Will apply them ASAP

msgid ""
"JSON meta information about the task, such as information on child tasks"
msgstr ""
"JSON мета информация о Задании, такая как информация о дочерних Заданиях"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be «метаинформация» instead of «мета информация»


#: django_celery_results/models.py:92
msgid "task results"
msgstr "результаты задания"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is verbose_name_plural — a name for multiple instances of a task result, so it would be better as «результаты заданий»

msgid ""
"JSON serialized list of task result tuples. use .group_result() to decode"
msgstr ""
"JSON сериалованный список таплов результата задания. Используйте .group_result() для декодирования"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google trends show that «кортеж» из more popular translation for Tuple then «тапл»

@auvipy
Copy link
Member

auvipy commented Nov 12, 2021

fixes are welcome

@f213 f213 mentioned this pull request Nov 13, 2021
@f213
Copy link
Contributor

f213 commented Nov 13, 2021

I created #256 with suggested fixes, could you guys please check it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants