Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.0 #465

Closed
Uninen opened this issue Dec 8, 2021 · 49 comments · Fixed by #528
Closed

Add support for Django 4.0 #465

Uninen opened this issue Dec 8, 2021 · 49 comments · Fixed by #528
Assignees
Milestone

Comments

@Uninen
Copy link

Uninen commented Dec 8, 2021

First, Thanks for this great project! 👍

Summary:

Current django-celery-beat requires Django (>=2.2,<4.0) and hence doesn't install together w/ Django 4.0.

@tari
Copy link

tari commented Dec 8, 2021

#435 updated to <4.1, so there simply needs to be a new release it seems.

@Uninen
Copy link
Author

Uninen commented Dec 8, 2021

Oh, didn't notice that, good catch 👍

@dorukgezici
Copy link

Yeah, we are waiting for the release as well.

@auvipy
Copy link
Member

auvipy commented Dec 10, 2021

was on vacation. I will clear my backlogs and release this soon

@Melevir
Copy link

Melevir commented Dec 13, 2021

I'm also waiting for the thing. Say if I can help somehow :)

@auvipy
Copy link
Member

auvipy commented Dec 13, 2021

i have a lots of release to make this week, just released py-amqp v5.0.7. have lil bit more patience in the mean time.

@omfd
Copy link

omfd commented Dec 24, 2021

@auvipy Thanks for the update! Awaiting the support for django 4.0

@auvipy
Copy link
Member

auvipy commented Dec 24, 2021

in the mean try install from master and report any issues

@Hesam-Taleghani
Copy link

Is there any updates here?

@auvipy
Copy link
Member

auvipy commented Jan 3, 2022

waiting for django 4.0.1 release which is due tomorrow

@auvipy auvipy added this to the v2.3.0 milestone Jan 3, 2022
@mvaled
Copy link

mvaled commented Jan 6, 2022

@auvipy

I think we can mark this done. I've updated one of my apps to Django 4.0 using this repo's master branch and, so far, I haven't witnessed any issue.

@n6g7
Copy link

n6g7 commented Jan 7, 2022

master branch seems to work but I'm not a fan of using it in production deployments.
@auvipy is there anything anyone can do to help with the release?

@auvipy
Copy link
Member

auvipy commented Jan 8, 2022

just can you tell that using the master branch with django 4.0.1 create any new no-op migrations?

@mvaled
Copy link

mvaled commented Jan 8, 2022

No migrations were detected. I'm actually using this:

django-celery-beat = { git = "https://github.com/celery/django-celery-beat.git", rev = "fa73034be892052893e4ef17926ef3a5d4a21ea2" }

with Django 4.0.1.

@auvipy
Copy link
Member

auvipy commented Jan 9, 2022

thanks, I will try to release both django integration tomorrow. taking rest today as last 2 days and one night I was busy with my wife's medical emergency.

@AlexDaniel
Copy link

Thank you, @auvipy, take care! Yes, we're also waiting for a release, but it's not as urgent. Thank you for your continuous support and maintenance! ♥

@root4417
Copy link

Hi there, Thanks for such a great thing. Can you enable Django 4.0 ? Because currently it's not installing with Django 4.0. Please release a version.

@auvipy
Copy link
Member

auvipy commented Jan 18, 2022

I am little bit fatigued in chilly winter. allow me couple of days for release

@domdinicola
Copy link

thanks, I will try to release both django integration tomorrow. taking rest today as last 2 days and one night I was busy with my wife's medical emergency.

hope everything is good, take your time and thanks!

@auvipy auvipy self-assigned this Jan 19, 2022
@root4417
Copy link

root4417 commented Jan 21, 2022

@auvipy I hope you are doing well. Is there any update on this issue? When we can expect a release?

@auvipy
Copy link
Member

auvipy commented Jan 22, 2022

for those benefited from the celery django integration packages consider donating through https://opencollective.com/celery this will support my time.

@root4417
Copy link

@auvipy I hope you're doing well. We'd like to know more about this issue. Is there going to be a new release,

@auvipy
Copy link
Member

auvipy commented Jan 28, 2022

you people do me a favor? if possible try to review the open PR's on this milestone, try them locally and left your review.
https://github.com/celery/django-celery-beat/milestone/2

@mvaled
Copy link

mvaled commented Jan 29, 2022

@auvipy I will set aside some time during the week to check #462. As a matter of fact I'm running with Django 4.0 and Python 3.10 for some time now using

django-celery-beat = { git = "https://github.com/celery/django-celery-beat.git", rev = "fa73034be892052893e4ef17926ef3a5d4a21ea2" }

@insspb
Copy link

insspb commented Feb 10, 2022

@auvipy
Official support of Django 4 appears only in version 5 of https://github.com/mfogel/django-timezone-field
but current master beat restrict this version, causing conflict if both specified in external project config

@daggaz
Copy link

daggaz commented Feb 16, 2022

@insspb I don't think there's any hard incompatibility with django-timezone-field 5.0. The requirement looks like it's just been pinned to <5 to be safe against future backward incompatibilities.

django-celery-beat doesn't use the display_GMT_offset kwarg which has been removed in 5.0.

I do note however that django-timezone-field has dropped support for django 3.0 and 3.1 which means this project should presumably also drop support for those versions.

@auvipy
Copy link
Member

auvipy commented Feb 17, 2022

#514

@juancresc
Copy link

Is this releasing soon?

@Hesam-Taleghani
Copy link

I'm still waiting as well, is there anything we can help? @auvipy

@auvipy
Copy link
Member

auvipy commented Feb 28, 2022

you all can pray for me, I am suffering from post covid chronic fatigue :) though I am eating well and taking suppliments, I am not so strong yet. I restarted work today, and I have plans to clear all due releases.

@auvipy
Copy link
Member

auvipy commented Feb 28, 2022

however this #518 might be a blocker, can anyone confirm?

@AlexDaniel
Copy link

@auvipy get well! Here I had the damn thing twice, with long-lasting effects also but recovered fully (or so I think).

@auvipy
Copy link
Member

auvipy commented Mar 1, 2022

release a related version good peoples https://pypi.org/project/django-celery-results/2.3.0/ next is this in high prio Q! the delays were totally out of my control :)

@Uninen
Copy link
Author

Uninen commented Mar 1, 2022

Thanks! 🙏

Please don't stress about the releases. This is open source and people have lives. If someone wants to speed up the development, they can contribute either code or money.

@Hesam-Taleghani
Copy link

you all can pray for me, I am suffering from post covid chronic fatigue :) though I am eating well and taking suppliments, I am not so strong yet. I restarted work today, and I have plans to clear all due releases.

I have had it too, take care and thank you for your time

@googlina
Copy link

@auvipy
Hope you are doing well.
Just wanted to check if there is any update oh support for 4.0

@grimzy
Copy link

grimzy commented Mar 15, 2022

Related PR was merged although there are still a few other issues to close before release.

@NickWillems
Copy link

For people that need a quick but dirty workaround, I managed to get it working with Django 4.0.1 by installing the dependencies manually
pip install celery==5.2.3 django-timezone-field==4.2.3 python-crontab==2.3.4
pip install django-celery-beat==2.2.1 --no-deps

@rubiodamian
Copy link

any updates about this?

@APouzi
Copy link

APouzi commented Mar 31, 2022

For people that need a quick but dirty workaround, I managed to get it working with Django 4.0.1 by installing the dependencies manually pip install celery==5.2.3 django-timezone-field==4.2.3 python-crontab==2.3.4 pip install django-celery-beat==2.2.1 --no-deps

Worked for me. Don't see any issues with this at the moment, will try to run some tests on my applications and get back if anything wrong happens.
Still keeping track of this of this thread, hoping it gets fixed soon.

@charanjit-singh
Copy link

I am looking for support of Django==4.0.3

@Beenhakker
Copy link

For people that need a quick but dirty workaround, I managed to get it working with Django 4.0.1 by installing the dependencies manually pip install celery==5.2.3 django-timezone-field==4.2.3 python-crontab==2.3.4 pip install django-celery-beat==2.2.1 --no-deps

django-timezone-field v5 is already release with Django 4 support.

@Hesam-Taleghani
Copy link

Is there any update here? when we should expect the new version release?

@pnaoum
Copy link

pnaoum commented May 12, 2022

Django 4 support is badly needed, do we have any expected release date??

@auvipy
Copy link
Member

auvipy commented May 13, 2022

by 30th may hopefully but not before 20th may

@chaubeyaj98
Copy link

chaubeyaj98 commented May 21, 2022

@auvipy really needed this updated coz we are stuck while updating to django 4.0

@APouzi
Copy link

APouzi commented May 21, 2022

Its interesting, to those of you who really need it, are you guys donating to make sure it goes along faster?
Its one thing to ask that if you are a financialy invested stakeholder, otherwise you guys are just going to have to accept whatever day they fix it......or fork it.

@RayyanNafees
Copy link

So does Celery now support Django 4+ ?

@auvipy
Copy link
Member

auvipy commented Jul 11, 2023

celery support that for a while now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.