security: SecureSerializer: support generic low-level serializers #8982
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8982 +/- ##
=======================================
Coverage 77.80% 77.81%
=======================================
Files 150 150
Lines 18686 18686
Branches 3193 3193
=======================================
+ Hits 14539 14540 +1
Misses 3854 3854
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@auvipy can you check when you have time, please? |
shirsa
force-pushed
the
main
branch
4 times, most recently
from
a5874b1
to
96a766d
Compare
Thanks @auvipy |
shirsa
force-pushed
the
main
branch
2 times, most recently
from
96a766d
to
9679a41
Compare
|
I restarted the build |
Thanks @auvipy . |
|
@auvipy Is there anything else you would like me to change/add here? |
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #8981
This PR adds 'data_type' as a new field to the metadata that is saved as part of
SecuredSerializerserialization.This info enable us to encode/decode the original data, in order to be fit to the expected input of our serializer, without the need to assume its type when decoding (for example, today there is assumption that if the decided value is
bytes, then the original data was of typestring. This assumption also breaks other serializers that outputs 'binary' format, such aspickle.