Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (04af085) to head (0cc735b).

@@            Coverage Diff             @@
##             main    #8984      +/-   ##
==========================================
- Coverage   77.81%   77.81%   -0.01%     
==========================================
  Files         150      150              
  Lines       18686    18686              
  Branches     3193     3193              
==========================================
- Hits        14541    14540       -1     
  Misses       3854     3854              
- Partials      291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke Fixed the issues in main that broke this PR, also fixed a typo.

I’m thinking out loud about merging this and releasing a patch version (v5.4.1), WDYT?

The API originally did not return None? a.k.a API change? Or is it a stretch to call this an API change 🤔

@browniebroke now it's more understandable than before 🚀

@browniebroke Fixed the issues in main that broke this PR, also fixed a typo.

I’m thinking out loud about merging this and releasing a patch version (v5.4.1), WDYT?

The API originally did not return None? a.k.a API change? Or is it a stretch to call this an API change 🤔

No way, is too much a "API change"?
although is not a different return, is a clarify return

The API originally did not return None? a.k.a API change? Or is it a stretch to call this an API change 🤔

It did return None, it's just that there was a return statement, and the None was coming from the underlying Django API. Now, the Celery method doesn't return anything, making it more explicit.

I’m thinking out loud about merging this and releasing a patch version (v5.4.1), WDYT?

I don't think there is any rush to release a fix for this, the behaviour hasn't actually changed. The main change is in the docs IMO.

Yup, you two are right - I didn't notice the nuance.

Thank you for collaborating to fine tune the API!