Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose retry_policy for Redis result backend #6330

Merged
merged 1 commit into from Sep 9, 2020

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Sep 2, 2020

Rather than adding a new top-level config option, I have used a new key
in the already existing setting result_backend_transport_options.

Fixes #6166

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2020

This pull request fixes 1 alert when merging 5eb36e8 into 7ba1b46 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2020

This pull request fixes 1 alert when merging c8dd9cc into 7ba1b46 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@ashb
Copy link
Contributor Author

ashb commented Sep 2, 2020

Test failed due to an apt-get timeout (i.e. random failure)

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2020

This pull request introduces 1 alert and fixes 1 when merging d057e08 into 7ba1b46 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Non-exception in 'except' clause

@ashb
Copy link
Contributor Author

ashb commented Sep 2, 2020

@auvipy PTAL/restart CI when you have a few spare cycles? Thanks.

@auvipy auvipy added this to the 5.0.0 milestone Sep 6, 2020
celery/backends/redis.py Outdated Show resolved Hide resolved
@auvipy auvipy closed this Sep 6, 2020
@auvipy auvipy reopened this Sep 6, 2020
celery/backends/redis.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2020

This pull request introduces 1 alert when merging 7a365b3 into 465d267 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the lint errors related?

@thedrow
Copy link
Member

thedrow commented Sep 9, 2020

are the lint errors related?

Yes they are.

Copy link
Member

@thedrow thedrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the lint failures.

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2020

This pull request introduces 1 alert when merging 2a05c6f into 465d267 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

Rather than adding a new top-level config option, I have used a new key
in the already existing setting `result_backend_transport_options`.

Closes celery#6166
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2020

This pull request introduces 2 alerts when merging f6198f5 into 465d267 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@ashb
Copy link
Contributor Author

ashb commented Sep 9, 2020

Travis/linted tests passing now.

@ashb ashb requested a review from thedrow September 9, 2020 15:51
@auvipy auvipy merged commit b08efaa into celery:master Sep 9, 2020
@ashb ashb deleted the redis-retry-policy branch September 10, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose config option to set retry_policy on (Redis) ResultBackend
3 participants