Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.4.0 #5816

Closed
5 tasks done
thedrow opened this issue Nov 4, 2019 · 18 comments
Closed
5 tasks done

Release 4.4.0 #5816

thedrow opened this issue Nov 4, 2019 · 18 comments

Comments

@thedrow
Copy link
Member

thedrow commented Nov 4, 2019

Version: 4.4.0
Release PR: TDB

Checklist

  • Release PR drafted

  • Release PR reviewed

  • The master branch build passes

    Build Status

  • Release Notes

  • What's New

Release Blockers

https://github.com/celery/celery/milestone/22

Potential Release Blockers

https://github.com/celery/kombu/milestone/6

@thedrow thedrow added this to the 4.4.0 milestone Nov 4, 2019
@thedrow thedrow self-assigned this Nov 4, 2019
@thedrow thedrow pinned this issue Nov 4, 2019
@thedrow
Copy link
Member Author

thedrow commented Nov 5, 2019

@auvipy Can you please bring me up to speed?
What needs to be done?
What's blocking us from a release?

@auvipy
Copy link
Member

auvipy commented Nov 5, 2019

  1. Changelog for 4.4 does not meet the project's standards #5607 this one is main blocker. among other blocker, some issues are already closed. I will update you the remaning tomorrow.

@auvipy auvipy self-assigned this Nov 6, 2019
@auvipy
Copy link
Member

auvipy commented Nov 6, 2019

I will release a 4.4rc4 by 7, Nov and planning to make a stable release by 14/15 nov. I will work dedicatedly from today to cea the blocker an release 4.4rc3 by 7 November.

@Darkheir
Copy link
Contributor

Hey, out of curiosity what is missing before releasing the final version ?

@auvipy
Copy link
Member

auvipy commented Nov 19, 2019

a release note with project standard + 1 integration fail error. expect 30 nov as the stable release day

@Darkheir
Copy link
Contributor

Awesome, thanks !

@lpsinger
Copy link
Contributor

lpsinger commented Dec 2, 2019

How is Celery 4.4.0 coming?

@auvipy
Copy link
Member

auvipy commented Dec 2, 2019

this week end :)

@xirdneh
Copy link
Member

xirdneh commented Dec 3, 2019

@auvipy Is there anything I can do to help?

@auvipy
Copy link
Member

auvipy commented Dec 3, 2019

@auvipy Is there anything I can do to help?

yes please #5817 :D if you have time

@xirdneh
Copy link
Member

xirdneh commented Dec 6, 2019

@auvipy I've started going through the commits and seeing what's missing. Will continue over the weekend.

@auvipy
Copy link
Member

auvipy commented Dec 7, 2019

Considering the fact that we added some new features and bug fixes in the 4.4.x master development branch, I have released another release candidate https://github.com/celery/celery/releases/tag/4.4.0rc5 and proposing the final release in 1 week.

@lioncui
Copy link

lioncui commented Dec 11, 2019

Hi, What time to merge with #5482 ?
I want to fix the memory leek problem.
Thank you very much!

@auvipy
Copy link
Member

auvipy commented Dec 11, 2019

Hi, What time to merge with #5482 ?
I want to fix the memory leek problem.
Thank you very much!

can you add unit and integration test for that PR?

@thedrow
Copy link
Member Author

thedrow commented Dec 13, 2019

@lioncui We haven't merged the PR since we don't know if it fixes the issue and if it does, we don't know why it fixes the issue.

See #5482 (comment).

It's possible that after the release we'll introduce a setting to turn this behavior off if you experience a memory leak.

@thedrow
Copy link
Member Author

thedrow commented Dec 15, 2019

I'm nearly done with the what's new but I need to rewrite the changelog to be up to the project's standard.
We're very close to a release.

@auvipy
Copy link
Member

auvipy commented Dec 16, 2019

I have released the 4.4.0 version on PyPI. with minimal what's new on 4.4.0. we can fix the bugs and release notes as per-project standards on 4.4.x milestone. thank you all for your support. This was my first ever major release of celery, so there were some mistakes in the release process and timing. My apologies for those and I have learn a lot in the meantime.

@auvipy auvipy closed this as completed Dec 16, 2019
@auvipy auvipy unpinned this issue Dec 16, 2019
@thedrow
Copy link
Member Author

thedrow commented Dec 16, 2019

So you released before we were ready for it?
I don't get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants