Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why there's not a classic thread pool #5307

Closed
tinylambda opened this issue Jan 25, 2019 · 2 comments
Closed

Why there's not a classic thread pool #5307

tinylambda opened this issue Jan 25, 2019 · 2 comments

Comments

@tinylambda
Copy link

tinylambda commented Jan 25, 2019

We have prefork, eventlet/gevent pools, and can run worker in solo mode.

it looks like that solo-mode worker is a single thread worker, but it's not really a pool. it does not support warm shutdown correctly(all tasks in solo-mode worker will shutdown immediately but not to wait them to finish when stopping the worker, event after setting CELERY_ACKS_LATE=True)

If we can have a classic thread pool, we can use a thread as main thread to control the pool, other threads will take the workloads.

@clokep
Copy link
Contributor

clokep commented Jan 25, 2019

I think there's a PR to add this, see #5099.

@tinylambda
Copy link
Author

I think there's a PR to add this, see #5099.

Cool~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants