Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS NAPI Buffer error #64

Closed
oyed opened this issue Feb 5, 2023 · 7 comments
Closed

macOS NAPI Buffer error #64

oyed opened this issue Feb 5, 2023 · 7 comments

Comments

@oyed
Copy link

oyed commented Feb 5, 2023

Hi! Just upgraded the library and Electron to 22, however I'm now getting an error on init calls;

Error: Failed to create napi buffer

@whaqzhzd
Copy link

whaqzhzd commented Feb 7, 2023

just upgrade the napi fix

@oyed
Copy link
Author

oyed commented Feb 7, 2023

cc @ceifa

@James226
Copy link
Contributor

Definitely seeing some of these coming from getSessionTicket on M1 chips, but haven't had too much time to look into it yet. Those calls do seem fine on Windows though... (I don't have an Intel Mac to check that variant)

@James226
Copy link
Contributor

James226 commented Feb 12, 2023

I've just raised #66 to bump the compiled version for darwin-arm64 which should stop these errors over there.

I did notice Github Actions now support M1, so might be nice to get this in at some point!

@ceifa
Copy link
Owner

ceifa commented Feb 12, 2023

I've just raised #66 to bump the compiled version for darwin-arm64 which should stop these errors over there.

@oyed can you confirm you are running into this problem only on apple M1/M2 chips?

I did notice Github Actions now support M1, so might be nice to get this in at some point!

Nop, no support yet. Only for self-hosted machines.

@oyed
Copy link
Author

oyed commented Feb 20, 2023

Apple M1 Max @ceifa

@oyed oyed changed the title NAPI Buffer error macOS NAPI Buffer error Feb 20, 2023
@ceifa
Copy link
Owner

ceifa commented Feb 24, 2023

Fixed on 0.0.29

@ceifa ceifa closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants