Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(tech debt) Remove HEADER_SPAN hack #557

Open
Chriscbr opened this issue Jan 13, 2022 · 1 comment
Open

(tech debt) Remove HEADER_SPAN hack #557

Chriscbr opened this issue Jan 13, 2022 · 1 comment

Comments

@Chriscbr
Copy link
Contributor

Chriscbr commented Jan 13, 2022 •
edited

The markdown renderer has a small hack when rendering headers that allows the "HEADING_SPAN" environment variable to be passed to replace all anchors with <span> tags with data-attribute properties. I think this hack exists so that anchors can be rendered properly on Construct Hub using the prism-react-renderer component.

Once the Construct Hub has switched to rendering API references directly from API.json files, we can remove this hack.
@Chriscbr Chriscbr mentioned this issue Jan 13, 2022
Merged
@github-actions
Copy link
Contributor

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Mar 15, 2022
@Chriscbr Chriscbr removed the stale label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Chriscbr