Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from Annotations addWarning to addWarningV2 #1418

Open
JohannesKonings opened this issue Aug 26, 2023 · 1 comment
Open

switch from Annotations addWarning to addWarningV2 #1418

JohannesKonings opened this issue Aug 26, 2023 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@JohannesKonings
Copy link
Contributor

JohannesKonings commented Aug 26, 2023 •
edited

General Issue

Deprecation Warning from CDK because of cdk-nag

The Question

It looks like cdk deprecated the addWarning.

Warnings from cdk-nag has now an addintional Warning from cdk:

[WARNING] aws-cdk-lib.Annotations#addWarning is deprecated.
  - use addWarningV2 instead
  This API will be removed in the next major release.

cdk-nag version

2.27.112

Language

Typescript

Other information

Here are some more information about the addWarningV2:
aws/aws-cdk#26144
@JohannesKonings JohannesKonings added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Aug 26, 2023
@dontirun dontirun mentioned this issue Aug 28, 2023
Open
2 tasks
@dontirun dontirun added feature-request A feature should be added or improved. and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2023
@dontirun
Copy link
Collaborator

@JohannesKonings Thanks for bringing this up!

After looking into this I don't think that switching to addWarningV2 is the best/optimal choice. I've opened issue aws/aws-cdk#26914 to discuss further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dontirun @JohannesKonings