Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end tests: Use a better mechanism to compare CloudFormation templates #506

Open
madeline-k opened this issue Jan 16, 2024 · 0 comments

Comments

@madeline-k
Copy link
Collaborator

The end-to-end tests currently use git diff to compare input and output CloudFormation templates. This is not sophisticated enough, because files of two templates may look different, even when the CloudFormation templates are equivalent.

A couple options to implement a more advance mechanism here:

  1. Do JSON object comparison. We should also consider automatically resolving differences where the JSON is different, but the CloudFormation templates are equivalent.
  2. Create a CloudFormation stack from the original template, then do a cdk diff with the new stack. This will have challenges with handling credentials if we want to do it in a pipeline or in GitHub actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant