CDI-681 Spec doesn't talk about BeanConfigurator.read method #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec still does not mention |
|
branch mixup. thx |
mkouba
reviewed
Jan 12, 2017
| @@ -1194,6 +1194,7 @@ CDI 2.0 introduced the `javax.enterprise.inject.spi.configurator.BeanConfigurato | |||
|
|
|||
| With `BeanConfigurator` you can perform all the operations defined in <<bean_attributes_configurator>> plus the following: | |||
|
|
|||
| * Read the bean metadata from a `BeanAttributes` or an `AnnotatedType` with one of its `read()` methods. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I would opt to incorporate something indicating that the configurator will be initialized with the metadata you read:
read()methods initiate the configurator with existingBeanAttributesorAnnotatedTypemetadata.
|
Looks good now |
|
I think it's ok. |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDI-681 Spec doesn't talk about BeanConfigurator.read method