Travis :: Optimize tests #16260
Travis :: Optimize tests #16260
Conversation
carlosmiei
commented
Dec 29, 2022
carlosmiei
commented
- added a tests manager that will run everything once a day
- otherwise, only affected exchanges are tested, unless it's some structural change (inside base, tests, etc)
| @@ -1215,7 +1215,7 @@ module.exports = class bybit extends Exchange { | |||
| // "nextPageCursor": "" | |||
| // }, | |||
| // "retExtInfo": {}, | |||
| // "time": 1667533491917 | |||
| // "time": 1667533491916 | |||
There was a problem hiding this comment.
dummy change just to check if bybit's tests are triggered
carlosmiei
force-pushed
the
optimize-tests
branch
from
f48157e
to
22f7372
Compare
tests-manager.js
Outdated
| return; | ||
| } | ||
|
|
||
| const shouldRunEverything = stdout.indexOf ("Exchange") > -1 || |
There was a problem hiding this comment.
Just as a doubt, maybe there are other files beyond these predefined clauses, which might be missing? i.e. some changes in root directory (say keys.json or dependency version in package.sjon or etc.. any file in root directory), or something in dependencies or etc... In the past, I thought that more reliable way could be inverted logic - "...if there is at least one file, that doesn't match derived exchange file path.."
so, iterate through changed files and find if there is even one occurrence where filepath !== './js/${exchangeName}.js && ! filepath.includes('/examples/) then set flag to true.
wdyt?
There was a problem hiding this comment.
@ttodua the thing is, both whitelisting and blacklisting are tricky here, we don't want to run tests, for example if the docs or examples are updated, but we want if run-tests or run-tests-ws are, so I don't think there is a "one size fits all" rule here
There was a problem hiding this comment.
but why not blacklist instead of whitelist? i mean, it's easier to check imo : filepath !== './js/${exchangeName}.js && ! filepath.includes('/examples/) && ! filepath.includes('/docs/), because as I said, many things seem to be missing from the whitelisted (not only run-tests but other files that should cause full re-tests/re-build)
|
i've reduced the number of bytes by 75% by rewriting it in bash
|
|
also will refactor so it just runs once for both pro and rest |
It's perfect. but for the next cases, please note there is a side-effect - writing in JS has an advantage that most of us will be able to read/edit too, as personally I am not skilled in bash and can't navigate through it :/ I understand, it's in safe hands under you, so no problem, but also in future cases, if the filesize is not critical, maybe we might leave such codes in js. |
