Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples - ohlcv and balance #16216

Merged
merged 1 commit into from Dec 28, 2022
Merged

Conversation

ttodua
Copy link
Member

@ttodua ttodua commented Dec 26, 2022

I really believe that such many examples on same thing (fetching ohlcv with just different variable namings and periphericals) was too much confusing, and it would lead more frustration than benefit. The typical signature is already mentioned in manual, but for "an example" advanced usage, I've tried to put it in one example file, where it demonstrates how to download "multiple symbols ohlcvs" parallely, including the "from-to" diapason variables.

also removed duplicate "fetch-balance" snippets, also, there were API KEYs leakage (probably already dead, but still..).

@ttodua
Copy link
Member Author

ttodua commented Dec 27, 2022

@frosty00

@frosty00
Copy link
Member

i think the merge script is fixed now

@frosty00 frosty00 merged commit 70068be into ccxt:master Dec 28, 2022
@ttodua ttodua deleted the js-examples-cleanup branch December 28, 2022 10:57
@ttodua
Copy link
Member Author

ttodua commented Dec 28, 2022

i think the merge script is fixed now

good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants