gemini - fetchMarketsFromApi #15862
Merged
gemini - fetchMarketsFromApi #15862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
carlosmiei
reviewed
Nov 29, 2022
carlosmiei
reviewed
Dec 16, 2022
js/gemini.js
Outdated
| @@ -1317,7 +1402,7 @@ module.exports = class gemini extends Exchange { | |||
| } | |||
|
|
|||
| nonce () { | |||
| return this.milliseconds (); | |||
| return this.seconds (); | |||
There was a problem hiding this comment.
@pcriadoperez btw why are we doing this?
check this for context: #16066 and let me know if you have additional info pls
There was a problem hiding this comment.
@carlosmiei I think that it should be this.seconds I can't get gemini to work, and the solution is to change to this.seconds
|
I was having the same issue as the other user and also saw Gemini fetchTime
returned in seconds, but I changed it back to milliseconds after seeing
your comments in the issue
…On Fri, Dec 16, 2022, 1:23 PM Carlos Gonçalves ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In js/gemini.js
<#15862 (comment)>:
> @@ -1317,7 +1402,7 @@ module.exports = class gemini extends Exchange {
}
nonce () {
- return this.milliseconds ();
+ return this.seconds ();
@pcriadoperez <https://github.com/pcriadoperez> btw why are we doing this?
check this for context: #16066 <#16066>
and let me know if you have additional info pls
—
Reply to this email directly, view it on GitHub
<#15862 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC4UR7H7IIRZJGCJ7O2JS2LWNRNKXANCNFSM6AAAAAASNU4RFY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
LGTM ✅ |
carlosmiei
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16036
gemini Nonce '1669661118488' is not within 30 seconds of server time '1669661120''Test createOrder