Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE not included in sdist #13

Closed
cbrnr opened this issue Aug 12, 2021 · 2 comments · Fixed by #17
Closed

LICENSE not included in sdist #13

cbrnr opened this issue Aug 12, 2021 · 2 comments · Fixed by #17

Comments

@cbrnr
Copy link
Owner

cbrnr commented Aug 12, 2021

I noticed that our LICENSE is not included in the source package. However, when I build it locally with python setup.py sdist, this file is actually copied into the package. I suspect this is because the CI environment is using older versions of setuptools etc., so it might be worth updating packages? Alternatively, maybe it is already sufficient if we build on Python 3.9 instead of 3.7 here?

@hofaflo
Copy link
Collaborator

hofaflo commented Aug 15, 2021

Right, your suspicion is confirmed by the setuptools changelog and corresponding PR. Testing your suggestion to use Python 3.9 locally with act lead to the license being included, so that'd be a good solution!

@cbrnr
Copy link
Owner Author

cbrnr commented Aug 16, 2021

Nice, thanks for checking! I didn't know about act, this looks super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants