Support configurable start time - emailable report #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EmailableReport2` class provides test start time values which are in millisecond value from the epoch (01/01/1970 00:00:00): - sample value `1610359715103` - GMT : January 11, 2021 Monday 10: 08: 35.103 - see `test-output/emailable-report.html` for start time report usage - see https://www.epochconverter.com/clock This value is not very human readable, and this change adds a protected method which can be overridden in sub classes to provide a more human readable version of the test start time (e.g. `2021-01-01 12:34:56`) Fixes testng-team#2459
juherr
approved these changes
Feb 7, 2021
juherr
approved these changes
Feb 7, 2021
krmahadevan
approved these changes
Feb 7, 2021
|
@krmahadevan / @juherr may I ask when this feature/fix for this issue will be released? In other words, when is the next release of testng due, so that I can start using the new feature I added in this PR in my other projects which implement/run testng tests? |
|
@bazzani - It should be released this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EmailableReport2class provides test start time values whichare in millisecond value from the epoch (01/01/1970 00:00:00):
1610359715103test-output/emailable-report.htmlfor start time report usageThis value is not very human readable, and this change adds a protected
method which can be overridden in sub classes to provide a more human
readable version of the test start time (e.g.
2021-01-01 12:34:56)Fixes #2459.
Did you remember to?
CHANGES.txt