Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2469 #2470

Merged
merged 5 commits into from Feb 3, 2021
Merged

Issue #2469 #2470

merged 5 commits into from Feb 3, 2021

Conversation

aditya-qapitol
Copy link
Contributor

Fixes #2469

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all tests pass.
Just some minor remarks.

src/test/java/test/listeners/AlterSuiteListenerTest.java Outdated Show resolved Hide resolved
src/test/java/test/listeners/AlterSuiteListenerTest.java Outdated Show resolved Hide resolved
src/test/java/test/listeners/AlterSuiteListenerTest.java Outdated Show resolved Hide resolved
Copy link
Member

@krmahadevan krmahadevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please help fix the observation

@krmahadevan krmahadevan merged commit 7fed142 into testng-team:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters added in XmlTest during AlterSuiteListener not available in SuiteListener
3 participants