Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement serializer for Html #86

Merged
merged 1 commit into from Aug 30, 2022
Merged

Implement serializer for Html #86

merged 1 commit into from Aug 30, 2022

Conversation

TonalidadeHidrica
Copy link
Contributor

Fixes #85

@cfvescovo
Copy link
Collaborator

LGTM

@cfvescovo
Copy link
Collaborator

@teymour-aldridge could you double-check?

teymour-aldridge
teymour-aldridge approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@teymour-aldridge teymour-aldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I'm not terribly familiar with this code.

@cfvescovo cfvescovo merged commit 8a53f01 into causal-agent:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teymour-aldridge teymour-aldridge teymour-aldridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serializing entire HTML
3 participants
@TonalidadeHidrica @cfvescovo @teymour-aldridge