Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency selectors is not on the last version #89

Closed
Elrendio opened this issue Sep 17, 2022 · 5 comments
Closed

Dependency selectors is not on the last version #89

Elrendio opened this issue Sep 17, 2022 · 5 comments

Comments

@Elrendio
Copy link

Current version used: 0.22
Last version: 0.23

Seems like just bump the version won't make a breaking change. A good practice is also to re-export the crate selectors to avoid users having to guess which version they should be using 馃槉
@Elrendio Elrendio changed the title Dependencies selectors is not on the last version Dependency selectors is not on the last version Sep 17, 2022
@teymour-aldridge
Copy link
Collaborator

IIRC there were some problems upgrading selectors when we tried, but they may have disappeared. A patch would be most welcome!

@cfvescovo
Copy link
Collaborator

@teymour-aldridge you're right.

I tried updating selectors but there was a compatibility issue with css-parser.

@cfvescovo
Copy link
Collaborator

@Elrendio if you have a patch feel free to open a PR. I will happily review it.

@cfvescovo
Copy link
Collaborator

cfvescovo commented Oct 9, 2022 •
edited

We cannot fix this right now because a refactor would be needed to update selectors. As I am not sure on what approach should be taken (we could either refactor to support the latest version of selectors or remove LocalNames completely, see #45), I set this as wontfix for now

@cfvescovo cfvescovo mentioned this issue Jan 10, 2023
Merged
@cfvescovo
Copy link
Collaborator

Solved in #99

@cfvescovo cfvescovo mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Elrendio @cfvescovo @teymour-aldridge