Recsys dcg #975
Merged
Recsys dcg #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflicts. @zkid18, could you fix it? 🙏 |
Scitator
previously requested changes
Oct 26, 2020
catalyst/metrics/ndcg.py
Outdated
|
|
||
| def dcg( | ||
| outputs: torch.Tensor, targets: torch.Tensor, | ||
| gain_function=lambda x: torch.pow(2, x) - 1, k=100 |
catalyst/metrics/ndcg.py
Outdated
| gain_function=lambda x: torch.pow(2, x) - 1, k=100 | ||
| ) -> torch.Tensor: | ||
| """ | ||
| Computes DCG@topk for the specified values of `topk`. |
catalyst/metrics/ndcg.py
Outdated
| gain_function=lambda x: torch.pow(2, x) - 1, k=100 | ||
| ) -> torch.Tensor: | ||
| """ | ||
| Computes nDCG@topk for the specified values of `topk`. |
catalyst/metrics/ndcg.py
Outdated
| list with computed ndcg@topk | ||
| """ | ||
| ideal_dcgs = dcg(targets, targets, gain_function, k) | ||
| ndcg = dcg(outputs, targets, gain_function, k) / ideal_dcgs |
There was a problem hiding this comment.
could we make something like
predicted_dcgs = dcg(outputs, targets, gain_function, k)
ndcg = predicted_dcgs / ideal_dcgs
| @@ -0,0 +1,45 @@ | |||
| import math | |||
There was a problem hiding this comment.
could we also add tests for dcg?
added 2 commits
October 26, 2020 14:55
This reverts commit 9950d7d. Removed movielens by mistake
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
Scitator
previously approved these changes
Nov 2, 2020
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
|
This pull request is now in conflicts. @zkid18, could you fix it? 🙏 |
|
This pull request is now in conflicts. @zkid18, could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
PS