Recsys hitrate

[zkid18]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contribution guide?
• Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
• Did you make sure to update the docs? We use Google format for all the methods and classes.
• Did you check the docs with make check-docs?
• Did you write any new necessary tests?
• Did you add your new functionality to the docs?
• Did you update the CHANGELOG?
• You can use 'Login as guest' to see Teamcity build logs.

Improvement of #887

Description

Related Issue

Type of Change

• Examples / docs / tutorials / contributors update
• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves an existing feature)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

[pep8speaks]

Hello @zkid18! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-07 04:14:23 UTC

[zkid18]

@Scitator take a look on hit-rate calculation and corresponding test. I'm not 100% about the correctness of the implementation.

[mergify]

This pull request is now in conflicts. @zkid18, could you fix it? 🙏

[elephantmipt]

hit instead of hiy

[Scitator]

k=10?

[mergify]

This pull request is now in conflicts. @zkid18, could you fix it? 🙏

Pull request has been modified.