New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MlflowLogger update #1258
MlflowLogger update #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
@@ -107,7 +107,7 @@ def flush_log(self) -> None: | |||
"""Flushes the logger.""" | |||
pass | |||
|
|||
def close_log(self) -> None: | |||
def close_log(self, scope: str = None) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add ScopeEnum
with available alternatives for scope selection?
something like https://github.com/catalyst-team/catalyst/blob/master/catalyst/contrib/utils/thresholds.py#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ and why do we need different scope support here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MlflowLogger has an option of nested runs.
So parent run is an experiment; child runs - stages. So to close some runs we need to close child runs on stage end and parent run on an experiment end.
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?latest
andminimal
requirements?Description
Added
log_artifact
and updatedclose_log
for MlflowLogger.Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: