Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engines refactoring #1243

Merged
merged 2 commits into from Jun 22, 2021
Merged

Engines refactoring #1243

merged 2 commits into from Jun 22, 2021

Conversation

Scitator
Copy link
Member

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

github-actions[bot]
github-actions bot reviewed Jun 22, 2021
View reviewed changes
catalyst/core/engine.py
# pass
@property
@abstractmethod
def device(self) -> Device:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
D102 Missing docstring in public method

catalyst/core/runner.py Outdated
@@ -286,6 +286,28 @@ def hparams(self) -> OrderedDict:
"""
return {}

@property
def _log_defaults(self) -> Dict:
return dict(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
C408 Unnecessary dict call - rewrite as a literal.

catalyst/engines/deepspeed.py Outdated
@@ -7,13 +7,12 @@

from catalyst.engines.torch import DeviceEngine
from catalyst.settings import SETTINGS
from catalyst.utils.distributed import mean_reduce, sum_reduce
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.mean_reduce' imported but unused

catalyst/engines/deepspeed.py Outdated
@@ -7,13 +7,12 @@

from catalyst.engines.torch import DeviceEngine
from catalyst.settings import SETTINGS
from catalyst.utils.distributed import mean_reduce, sum_reduce
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.sum_reduce' imported but unused

catalyst/engines/torch.py Outdated
RunnerOptimizer,
RunnerScheduler,
)
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.mean_reduce' imported but unused

catalyst/engines/torch.py Outdated
RunnerOptimizer,
RunnerScheduler,
)
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.sum_reduce' imported but unused

catalyst/engines/torch.py
return f"{self.__class__.__name__}(device='{self._device}')"

@property
def device(self) -> Device:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
D102 Missing docstring in public method

catalyst/engines/fairscale.py Outdated
@@ -11,7 +11,7 @@
from catalyst.engines.torch import DeviceEngine
from catalyst.settings import SETTINGS
from catalyst.typing import RunnerCriterion, RunnerModel, RunnerOptimizer, RunnerScheduler
from catalyst.utils.distributed import mean_reduce, sum_reduce
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.mean_reduce' imported but unused

catalyst/engines/fairscale.py Outdated
@@ -11,7 +11,7 @@
from catalyst.engines.torch import DeviceEngine
from catalyst.settings import SETTINGS
from catalyst.typing import RunnerCriterion, RunnerModel, RunnerOptimizer, RunnerScheduler
from catalyst.utils.distributed import mean_reduce, sum_reduce
from catalyst.utils.distributed import ddp_reduce, mean_reduce, sum_reduce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F401 'catalyst.utils.distributed.sum_reduce' imported but unused

@Scitator Scitator merged commit 7f63545 into master Jun 22, 2021
@mergify mergify bot deleted the engines-refactoring branch June 22, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@bagxi bagxi Awaiting requested review from bagxi bagxi is a code owner

@ditwoo ditwoo Awaiting requested review from ditwoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Scitator