Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data API update (PR ensemble) #1237

Merged
merged 7 commits into from Jun 28, 2021
Merged

Data API update (PR ensemble) #1237

merged 7 commits into from Jun 28, 2021

Conversation

Scitator
Copy link
Member

@Scitator Scitator commented Jun 16, 2021

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Updated Config API:

      train:
        _target_: torch.utils.data.DataLoader
        dataset:
          _target_: MNIST
          root: *dataset_root
          train: True
          transform: &transform
            _target_: transform.Compose
            transforms:
              - _target_: transform.ToTensor
              - _target_: transform.Normalize
                mean: [0]
                std: [1]
          download: True
        batch_size: &batch_size 32
        sampler:
          _target_: MiniEpochSampler
          data_len: 50000
          mini_epoch_len: 35000
          drop_last: true
          shuffle: per_epoch
        num_workers: 1
      valid:
        _target_: DataLoader
        dataset:
          _target_: MNIST
          root: *dataset_root
          train: False
          transform: *transform
          download: True
        batch_size: *batch_size
        shuffle: false
        num_workers: 1
        drop_last: false

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

* feat: get_dataset_from_params (config api and hydra) added

* datasets added into registry

* rm @staticmethod
bagxi and others added 4 commits June 17, 2021 00:47
* Update README.md

* feat: `get_transforms` PoC

* fix: HuberLoss workaround added (#1239)

Co-authored-by: Sergey Kolesnikov <scitator@gmail.com>
…` added (#1244)

* feat: support of nested lists and dicts added; instantiation from path to object added

* replace `_get_XXX_from_params` with `REGISTRY.get_from_params` in config API

* `ConfigRunner._get_loaders_from_params` added
@mergify
Copy link

mergify bot commented Jun 25, 2021

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

* feat: support of nested lists and dicts added; instantiation from path to object added

* replace `_get_XXX_from_params` with `REGISTRY.get_from_params` in config API

* support of `meta_factory` for `registry.get_from_params` added
@Scitator Scitator merged commit 08f7250 into master Jun 28, 2021
@mergify mergify bot deleted the develop branch June 28, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants