fix: loader, etc, etc #1174
Merged
fix: loader, etc, etc #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| prefix: deprecated alias for ``metric_key`` | ||
|
|
||
| Python example - loss is a weighted sum of cross entropy loss and binary cross entropy loss: | ||
|
|
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace
bagxi
previously requested changes
Apr 13, 2021
Comment on lines
+214
to
+219
| def on_loader_start(self, runner): | ||
| super().on_loader_start(runner) | ||
| self.meters = { | ||
| key: metrics.AdditiveValueMetric(compute_on_call=False) | ||
| for key in ["loss", "accuracy01", "accuracy03"] | ||
| } |
There was a problem hiding this comment.
What about removing on_loader_start/on_loader_end methods? I think it can make the example a little bit simpler?
| metrics: Union[str, List[str], Dict[str, float]] = None, | ||
| mode: Union[str, Callable] = "mean", | ||
| scope: str = "batch", | ||
| multiplier: float = 1.0, | ||
| prefix: str = None, |
There was a problem hiding this comment.
If prefix is depreciated maybe we should throw warning?
Comment on lines
+8
to
+14
| def _nan_to_num(tensor, nan=0.0): | ||
| tensor = torch.where(torch.isnan(tensor), torch.ones_like(tensor) * nan, tensor) | ||
| return tensor | ||
|
|
||
|
|
||
| # nan_to_num is available in PyTorch only from 1.8.0 version | ||
| NAN_TO_NUM_FN = torch.__dict__.get("nan_to_num", _nan_to_num) |
There was a problem hiding this comment.
In my opinion it will be better to check version of pytorch directly
if torch.__version__ >= "1.8.0":
from torch import nan_to_num
else:
define nan_to_num (tensor, nan=0.0):
tensor = torch.where(torch.isnan(tensor), torch.ones_like(tensor) * nan, tensor)
return tensor
|
moving CI issues and deprecations to the next PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?latestandminimalrequirements?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: