Readme update2 #1142

Scitator · 2021-03-28T07:22:35Z

Before submitting (checklist)

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contribution guide?
Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
Did you make sure to update the docs? We use Google format for all the methods and classes.
Did you check the docs with make check-docs?
Did you write any new necessary tests?
Did you check that your code passes the unit tests pytest . ?
Did you add your new functionality to the docs?
Did you update the CHANGELOG?

Description

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

I know, that I could join slack for pull request discussion.

…fixes

mergify · 2021-03-28T07:23:00Z

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

github-actions · 2021-03-28T07:30:53Z

catalyst/contrib/nn/modules/factorized.py

+from torch import nn
+
+
+class FactorizedLinear(nn.Module):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2021-03-28T07:30:53Z

catalyst/contrib/nn/modules/factorized.py

+        self.out_features = vh.size(1)
+
+    @staticmethod
+    def spectral_init(m, dim_ratio: Union[int, float] = 1):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2021-03-28T07:30:53Z

catalyst/contrib/nn/modules/factorized.py

+            # print(f"SVD eigenvalue share {s_share:.2f}%")
+        return u, vh
+
+    def extra_repr(self) -> str:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2021-03-28T07:30:53Z

catalyst/contrib/nn/modules/factorized.py

+            f"bias=True, dim_ratio={self.dim_ratio}"
+        )
+
+    def forward(self, x):


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

mergify · 2021-03-28T07:50:27Z

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

* readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle

* add movielens * First hitrate metric version * metrge with upstream * fix topk_map * fix error in map * tests for map * top_k ndcg * edit changelog * edit the tabs * check codestyle * check the intent * check the intent * remove trailing whitespace * fixed hitrate * fixed the docs * hitrate * Additive margin softmax (#1131) * Added Additive-margin softmax * update changelog.md * Readme update2 (#1142) * readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle * updated dl_cpu(workflows)- For passing CI-Tests (#1135) * updated dl_cpu * Updated-requirements-ml.txt * corrected the mistake * Update dl_cpu.yml * Update requirements-ml.txt * Kept dl_cpu 20.04-3.6 minimal as requested * Corrected the mistakes * Add requirements parameter * Update dl_cpu.yml * Update dl_cpu.yml Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * fix: `_key_value` for schedulers in case of multiple optimizers fixed (#1146) * Github CI fixes (#1143) * verbose * Utils callbacks (#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com> * Engine docs (#1141) * typings & few docs * typing fix; disabled `dist.barrier()` in optimizer step for ddp * docs * docs: fixed long lines with docs * docs fixes * optimizer args * removed empty line Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> * v21.03.1 * v21.03: minimal version fix (#1147) * minimal version fix * docs * fix: nested dicts in loaders_params/samplers_params overriding (#1150) * docs (#1152) * Github CI fix (#1148) * fix * fix * Niftireader (#1151) * changes for NiftiReader * adding import statement that was needed and fixing codestyle * updated CHANGELOG * removing unnecesary documentation * fixing codestyle * updated docs and requirements * adding a space * not importing nibabel for docs * fixing typo * adding step for contrib pip caching * fixed codestyle and added a test for reader that uncovered a mistake :) * hopefully fixing imports * adding sergey suggested fix * fixing deploy_push.yml * updating workflows Co-authored-by: Kevin Wang <kevin.wang@affectiva.com> Co-authored-by: Kevin Wang <kcwang26@gsu.edu> * add changelog * solved runtime error * hitrate calculation Co-authored-by: Daniel Chepenko <dchepenk@yahoo-corp.co> Co-authored-by: denyhoof <kde97@yandex.ru> Co-authored-by: Даниил <zkid18@MacBook-Pro.Dlink> Co-authored-by: Atharva Phatak <athp456@gmail.com> Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> Co-authored-by: Yauheni Kachan <19803638+bagxi@users.noreply.github.com> Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com> Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> Co-authored-by: Kevin Wang <kcwang@ymail.com> Co-authored-by: Kevin Wang <kevin.wang@affectiva.com> Co-authored-by: Kevin Wang <kcwang26@gsu.edu>

* readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle

Scitator added 6 commits March 25, 2021 08:28

readme

f174050

batch overfit fix for reproducibility

5578a42

batch overfit fix for reproducibility

eb8d3f3

Merge branch 'master' of github.com:catalyst-team/catalyst into data-…

00fe6f5

…fixes

readme

c71de89

readme update

74c111f

Scitator requested review from bagxi and ditwoo as code owners March 28, 2021 07:22

readme update

6680dca

github-actions bot reviewed Mar 28, 2021

View reviewed changes

extra Config/Hydra API fixes

8985dc2

Scitator mentioned this pull request Mar 28, 2021

fix: outdated code (in get_optimizer) removed #1138

Closed

15 tasks

Scitator added 2 commits March 28, 2021 10:53

extra Config/Hydra API fixes

adf7aa3

codestyle

c6ec48e

Scitator merged commit 6f8c0b4 into master Mar 28, 2021

mergify bot deleted the readme-update2 branch March 28, 2021 08:54

zkid18 pushed a commit to zkid18/catalyst that referenced this pull request Apr 4, 2021

Readme update2 (catalyst-team#1142)

767b031

* readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle

zkid18 pushed a commit to zkid18/catalyst that referenced this pull request Jul 4, 2021

Readme update2 (catalyst-team#1142)

af70a7d

* readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Readme update2 #1142

Readme update2 #1142

Scitator commented Mar 28, 2021

mergify bot commented Mar 28, 2021

github-actions bot Mar 28, 2021

github-actions bot Mar 28, 2021

github-actions bot Mar 28, 2021

github-actions bot Mar 28, 2021

mergify bot commented Mar 28, 2021

Readme update2 #1142

Readme update2 #1142

Conversation

Scitator commented Mar 28, 2021

Before submitting (checklist)

Description

Related Issue

Type of Change

PR review

mergify bot commented Mar 28, 2021

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

github-actions bot Mar 28, 2021

Choose a reason for hiding this comment

mergify bot commented Mar 28, 2021