Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: CurricularFace #1013

Merged
merged 6 commits into from Dec 10, 2020
Merged

Conversation

ditwoo
Copy link
Contributor

@ditwoo ditwoo commented Nov 26, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Description

Paper: https://arxiv.org/abs/2004.00288

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

  • I know, that I could join slack for pull request discussion.

Copy link
Member

@Scitator Scitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests and check the codestyle?)

@ditwoo
Copy link
Contributor Author

ditwoo commented Dec 5, 2020

Please, don't merge this requests if all tests will be passed.
I need to check(test) that loss works as expected.

@Scitator Scitator added the WIP Pull request is under construction label Dec 6, 2020
@Scitator
Copy link
Member

Scitator commented Dec 6, 2020

sure, just remove WIP when you are done :respect:

@Scitator Scitator removed the WIP Pull request is under construction label Dec 10, 2020
@Scitator Scitator merged commit efbd292 into catalyst-team:master Dec 10, 2020
@ditwoo ditwoo deleted the feature/curricularface branch February 19, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants