Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp directory formatting breaks rubocop configuration #401

Closed
colinux opened this issue Jan 2, 2021 · 3 comments · Fixed by #403
Closed

Temp directory formatting breaks rubocop configuration #401

colinux opened this issue Jan 2, 2021 · 3 comments · Fixed by #403

Comments

@colinux
Copy link

colinux commented Jan 2, 2021

Last patch release 0.40.1 ignores .rubocop.yml files, because rubocop sees filepath of a temporary file, which is not in the directory of the .rubocop.yml workspace, so hierarchical config is not applied.

The diagnosis are not affected, because code is passed as stdin. v0.40.0 is ok.

@castwide
Copy link
Owner

castwide commented Jan 5, 2021

Confirmed. This is a nasty conundrum: autocorrect only works on a physical file (not stdin), and the -c argument for specifying the config doesn't work with autocorrect. That's how it appears for now, anyway. This issue's on the roadmap.

@jimeh
Copy link
Contributor

jimeh commented Jan 10, 2021

@colinux PR #403 should fix this issue. If you want to test the PR I'd be happy to try and resolve any issues you might run into.

@colinux
Copy link
Author

colinux commented Jan 25, 2021

I can confirm PR #403 works very well. Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants