Deleting obsolete Castle.Facilities.Logging code, handling FacilityConfig

[Jevonius]

While looking at adding net6.0 as a target, I took a look at Castle.Facilities.Logging (there is a reference to DiagnosticsLoggerFactory which theoretically can work under net6.0-win but not with the way the code is currently structured). I noticed how much is obsolete in this project, since 2017, so took a look at removing code.

I'm struggling with how to handle ReadLoggingApi:

Windsor/src/Castle.Facilities.Logging/LoggingFacility.cs

Lines 399 to 410 in 5a32d4f

	private LoggerImplementation ReadLoggingApi()
	{
	if (FacilityConfig != null)
	{
	var configLoggingApi = FacilityConfig.Attributes["loggingApi"];
	if (string.IsNullOrEmpty(configLoggingApi) == false)
	{
	return converter.PerformConversion<LoggerImplementation>(configLoggingApi);
	}
	}
	return loggerImplementation.GetValueOrDefault(LoggerImplementation.Console);
	}

The LoggerImplementation enum is marked obsolete, so looking at FacilityConfig.Attributes["loggingApi"] for the type to create is made more complicated. Any thoughts on how to handle this? Is configuration via FacilityConfig common?

[jonorossi]

The LoggerImplementation enum was marked obsolete to push people to use LogUsing<T>() rather than loggers being hardcoded in the library.

Without digging into the code and trying to replicate the same change I don't follow what the problems you are facing. Could you summarise your findings and what's a blocker?

[Jevonius]

The difficulty is in the part around reading FacilityConfig; I haven't really used this, so I'm not sure the use cases for it and whether it still needs to be supported, or to what level.
The code above is using the loggingApi configuration attribute to work out which LoggerImplementation to return, but that enum is marked obsolete.

My proposal, having had another read through the code, is that if FacilityConfig is used instead of LogUsing<T>(), it will be via the use of the FacilityConfig.Attributes["customLoggerFactory"] value - FacilityConfig.Attributes["loggingApi"] will no longer be available.

Does this seem reasonable?

[jonorossi]

Reopening after being automatically closed by #636. This one was about removing old code using FacilityConfig, not sure exactly, but reopen.