Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.2.0 #662

Open
stakx opened this issue Sep 1, 2023 · 1 comment
Open

Release 5.2.0 #662

stakx opened this issue Sep 1, 2023 · 1 comment
Milestone

Comments

@stakx
Copy link
Member

stakx commented Sep 1, 2023

I think we're almost ready for another release.


Things to do after this next release

I'd love if we could tackle those larger discussions about this library's (and DynamicProxy's) future, possibly resulting in a major version bump:

Depending on the outcome of those decisions, we may end up with a much slimmer library and a somewhat pared-down DynamicProxy implementation that's easier to manage, so I think it would be good to start there and get rid of as much "baggage" as soon as we can.

(If we decide to keep the logging abstractions, we could take a look at #418, which should be relatively straightforward.)

I'd also love to do some code exploration about whether we really need 5 different types of proxy; I suspect we have a lot of code duplication in DynamicProxy because of that. While working on #447, that suspicion has only increased, since one of the previously distinguishing characteristics of interfaces – that they may not contain any implementation bits – no longer holds true in modern C# and .NET. The distinction between class and interface proxies may no longer make sense. (Note that instead of CreateClassProxy<TClass>(), you can already do an practically equivalent (TClass)CreateInterfaceProxyWithoutTarget<IEmptyInterface>(new ProxyGenerationOptions { BaseTypeForInterfaceProxy = typeof(TClass) })). We could potentially cut the number of collectors / contributors / generators in half with only a few minor breaking changes, and simplify the public API of ProxyGenerator a lot.

@stakx stakx added this to the vNext milestone Sep 1, 2023
@stakx stakx pinned this issue Sep 1, 2023
@stakx
Copy link
Member Author

stakx commented Apr 6, 2024

I've been delayed with daytime (aka paid) work, but I think I'll find some time very soon to finally get DIM support published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant