Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log4Net not listed in dependencies #650

Closed
brettshearer opened this issue Feb 14, 2023 · 4 comments
Closed

Log4Net not listed in dependencies #650

brettshearer opened this issue Feb 14, 2023 · 4 comments

Comments

@brettshearer
Copy link

In 5.0.0 release notes:

Upgrade log4net to v2.0.13 (@jonorossi, @stakx, @dschwartzni, #574, #605)

Yet log4net doesn't appear in dependencies on this page:
https://www.nuget.org/packages/Castle.Core

Here is the reference:
https://github.com/castleproject/Core/blob/master/src/Castle.Services.Logging.SerilogIntegration/Castle.Services.Logging.SerilogIntegration.csproj

@stakx
Copy link
Member

stakx commented Feb 14, 2023

Seems like you're looking at the wrong project and at the wrong package.

The Castle.Core–log4net integration project is here:
https://github.com/castleproject/Core/blob/master/src/Castle.Services.Logging.log4netIntegration/Castle.Services.Logging.log4netIntegration.csproj

And the NuGet package is here:
https://www.nuget.org/packages/Castle.Core-log4net

And voilà, the dependency is right where it should be.

@stakx stakx closed this as completed Feb 14, 2023
@jonorossi
Copy link
Member

@brettshearer The second link you provided is the project file for Castle.Core-Serilog, not really sure why you provided that, the log4net project and package is:

@stakx
Copy link
Member

stakx commented Feb 14, 2023

Wow, almost identical answers with identical links at almost exactly the same time, @jonorossi. We must be quantum entangled or something.

@brettshearer
Copy link
Author

excellent - thanks. I'm in a massive entanglement session and got this wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants