Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration on start.spring.io #240

Open
casid opened this issue Jun 22, 2023 · 6 comments
Open

Integration on start.spring.io #240

casid opened this issue Jun 22, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@casid
Copy link
Owner

casid commented Jun 22, 2023

Quoting metalhead-001 from reddit, who asked about this in the jte 3 comments.

I really wish the Spring project would adopt this as one of the supported Spring Boot templating engines that show up on start.spring.io like Thyemeaf, Freemarker, etc. do. Have you considered attempting to get jte brought into Spring like the others?

As far as getting it integrated into start.spring.io, I think you would just have to open a pull request into the Spring project and include your starter with it...basically follow the same pattern as the Thymeleaf and Freemarker, etc. integrations.

I bet if you got that going they would be willing to accept it as they have accepted the other templating engines. There is also a bit of documentation that would have to be provided. Look at the documentation on the Thymeleaf integration here. Search for Thymeleaf on this 'one page' documentation and you can see everywhere it's documented. Similar documentation would have to be provided for jte.

https://docs.spring.io/spring-boot/docs/3.1.0/reference/htmlsingle/

@atomfrede do you think we should give this a try?

@atomfrede
Copy link
Contributor

Why not. It seems there is some kind of proposal process, so maybe we should start with creating such a proposal. But I could imagine it is easier as jte is "just" a template engine and not backed by a company like this proposal spring-io/start.spring.io#1114

@casid
Copy link
Owner Author

casid commented Jun 23, 2023

Oh yes, the proposal you linked looks frightening. I'm unsure if we are ready to commit to this.

@casid casid added the help wanted Extra attention is needed label Jun 23, 2023
@atomfrede
Copy link
Contributor

Should we try to create a proposal here together? At jcon a lot of people knew and asked Thomas and me about jte vs thymeleaf for example. So I would say there is some interest

@casid
Copy link
Owner Author

casid commented Jun 24, 2023

That would be awesome! What would be the best way to collaborate on a document like this? Best thing I could think of would be a branch with a markdown file in it?

Also, really cool to hear that people where asking about jte 😊

@tschuehly
Copy link
Contributor

tschuehly commented Jul 8, 2023

@casid
Yea I currently support 2 template engines in my library, and JTE is definitely the better option, for using with Spring ViewComponent.
Thymeleaf has a lot of Spring Magic, that you don't really need with server-side components.

I just need to get going on my compile time checker because then JTE would be completely type safe and null safe, cause currently JTE throws an error at runtime if a property that is declared as an parameter is not available in the model.

btw did you see my Spring I/O Talk? I also talked a bit about JTE there: https://youtu.be/DPAtQU-erM4?t=749

@casid
Copy link
Owner Author

casid commented Jul 9, 2023

@tschuehly great talk, thanks for sharing the video!

As for type-safety of params, maybe the new jte-models extension could be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants