Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create the database implementation #3540

Merged
merged 1 commit into from Sep 29, 2022
Merged

Always create the database implementation #3540

merged 1 commit into from Sep 29, 2022

Conversation

hfhbd
Copy link
Collaborator

@hfhbd hfhbd commented Sep 28, 2022

Fixes #3518

@hfhbd hfhbd self-assigned this Sep 28, 2022
AlecKazakova
AlecKazakova approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@AlecKazakova AlecKazakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you for the test case

@AlecKazakova AlecKazakova merged commit 5fc354d into master Sep 29, 2022
@AlecKazakova AlecKazakova deleted the hfhbd/alwaysDB branch September 29, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlecKazakova AlecKazakova AlecKazakova approved these changes

Assignees

@hfhbd hfhbd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always generate the database interface and its impl
2 participants
@hfhbd @AlecKazakova