Remove default params to flow extensions #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would rather be verbose and safe than introduce the default dispatcher unknowingly in situations where it would cause issues
JakeWharton
approved these changes
Sep 7, 2022
AlecKazakova
force-pushed
the
AlecStrong-patch-3
branch
from
0148964
to
386f070
Compare
AlecKazakova
force-pushed
the
AlecStrong-patch-3
branch
from
386f070
to
e85b33b
Compare
|
I'm curious what could go wrong. Did you have a specific example in mind? |
|
paging @jingibus !!!! |
The tl;dr is that while this is fantastic in prod, it really really hurts in testing. |
|
I see, thanks for the insights! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would rather be verbose and safe than introduce the default dispatcher unknowingly in situations where it would cause issues