Allow construction of OffsetQueryPagingSource with Long #3409
Conversation
| * @see toInt | ||
| */ | ||
| @Suppress("FunctionName") | ||
| fun <RowType : Any> QueryPagingSourceLong( |
There was a problem hiding this comment.
I'd prefer having this be the same name as the other function (QueryPagingSource) but we get a Platform declaration clash when doing so. Open to better names
There was a problem hiding this comment.
Should we just switch them so the Int one has a fancy name since SQLDelight users will pretty much only use this one?
There was a problem hiding this comment.
Using @JvmName should let you keep the names the same in Kotlin
There was a problem hiding this comment.
Nice, just renamed it to QueryPagingSource after specifying @JvmName.
@AlecStrong I just suffixed the type to each one for consistency in the @JvmName. I'm assuming that no one's using SQLDelight with Java.
| @@ -629,14 +629,40 @@ class OffsetQueryPagingSourceTest { | |||
| assertTrue(pagingSource.jumpingSupported) | |||
| } | |||
|
|
|||
| private fun query(limit: Int, offset: Int) = object : Query<TestItem>( | |||
| @Test | |||
| fun load_initialEmptyLoad_QueryPagingSourceLong() = runTest { | |||
There was a problem hiding this comment.
Just wanted a test to ensure that the constructor works as expected. This test is a copy of load_initialEmptyLoad, just using Long instead of Int.
| * @see toInt | ||
| */ | ||
| @Suppress("FunctionName") | ||
| fun <RowType : Any> QueryPagingSourceLong( |
There was a problem hiding this comment.
Should we just switch them so the Int one has a fancy name since SQLDelight users will pretty much only use this one?
veyndan
force-pushed
the
veyndan/2022-08-04/QueryPagingSourceLong
branch
from
00740af
to
35f38e6
Compare
No description provided.