fix: lock less when syncing #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @closetool @sagilio please review |
|
@tangyang9464 plz review |
| // Wait for at least one sync | ||
| time.Sleep(time.Millisecond * 300) | ||
|
|
||
| testEnforceSync(t, e, "bob", "data2", "write", true) |
There was a problem hiding this comment.
I added this as otherwise this test was also passing when the policy reloading failed.
|
@johanneswuerbach plz fix:
|
johanneswuerbach
force-pushed
the
background-sync
branch
from
59f633e
to
a9d0bd2
Compare
|
Thanks @hsluoyz, should be fixed now. |
johanneswuerbach
force-pushed
the
background-sync
branch
from
a9d0bd2
to
8a1a8a6
Compare
|
@tangyang9464 plz review |
tangyang9464
suggested changes
Apr 15, 2022
hsluoyz
added this to Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
johanneswuerbach
force-pushed
the
background-sync
branch
from
8a1a8a6
to
ea3dfd0
Compare
johanneswuerbach
force-pushed
the
background-sync
branch
from
ea3dfd0
to
60fcd04
Compare
|
🎉 This PR is included in version 2.44.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hsluoyz
removed this from Casbin Easy Tasks
in Casbin Easy Tasks for Beginners/Student Applicants
johanneswuerbach
added a commit
to johanneswuerbach/casbin
that referenced
this pull request
Jun 3, 2022
This reverts commit 756b994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock the
SyncedEnforceronly when replacing the model and not during the entire policy reload duration.Fixes #987