feat: Log panic stack #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @closetool @sagilio please review |
|
|
erichulburd
force-pushed
the
log_panic_stack
branch
from
62e07c7
to
db7b6ba
Compare
erichulburd
force-pushed
the
log_panic_stack
branch
from
db7b6ba
to
7a124bc
Compare
|
@tangyang9464 plz review |
|
🎉 This PR is included in version 2.44.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a couple of nil pointer exceptions that would have benefited from a stack reference. This simple adds the stack trace to the recovery error.