fix: multi-level inheritance with different domains #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abingcbc <abingcbc626@gmail.com>
|
@tangyang9464 @closetool @sagilio please review |
|
@amit-chandak-unskript plz review |
amit-chandak-unskript
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Thanks @Abingcbc for the quick turnaround, just verified my case and it works fine.
$ go run sampleCode/casbin/main.go
[[role:admin * *] [role:editor obj:runbook create] [role:editor obj:runbook update] [role:editor obj:runbook delete] [role:editor obj:credential create] [role:editor obj:credential update] [role:editor obj:credential delete] [role:editor obj:lego create] [role:editor obj:lego update] [role:editor obj:lego delete] [role:requestor obj:runbook request] [role:approver obj:runbook approver] [role:executor obj:runbook execute]]
[[group:editor role:editor domain1] [group:editor role:requestor domain2] [bob group:editor *]]
2021/12/13 07:26:07 Request: bob, domain1, obj:lego, create ---> true
Hit Policy:
true
|
🎉 This PR is included in version 2.40.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #929
How it works?
Refer to: #929 (comment)