Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CacheableParam interface #925

Merged
merged 1 commit into from Dec 4, 2021

Conversation

alikhanz
Copy link
Contributor

@alikhanz alikhanz commented Dec 3, 2021

Fix: #924

@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@alikhanz alikhanz force-pushed the feat-cacheable-abac branch 2 times, most recently from 0b414a9 to 3a2058d Compare December 3, 2021 23:10
@alikhanz alikhanz changed the title Add CacheableParam interface feat: Add CacheableParam interface Dec 3, 2021
@alikhanz alikhanz changed the title feat: Add CacheableParam interface feat: add CacheableParam interface Dec 3, 2021
Signed-off-by: Закиров Алихан <zakirov@tutu.ru>
@hsluoyz
Copy link
Member

hsluoyz commented Dec 4, 2021

lgtm

@hsluoyz hsluoyz merged commit 3d0481d into casbin:master Dec 4, 2021
@alikhanz
Copy link
Contributor Author

@hsluoyz can we release this merge in v2? I need this for continue my work

@hsluoyz
Copy link
Member

hsluoyz commented Dec 10, 2021

Hi @alikhanz the GitHub actions CI error has blocked the auto semantic-release. Can you take a look at why? https://github.com/casbin/casbin/runs/4414726653?check_suite_focus=true

@alikhanz
Copy link
Contributor Author

Hi @alikhanz the GitHub actions CI error has blocked the auto semantic-release. Can you take a look at why? https://github.com/casbin/casbin/runs/4414726653?check_suite_focus=true

Hello!
PR with fix here: #928

@hsluoyz
Copy link
Member

hsluoyz commented Dec 11, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Cacheable ABAC params
3 participants