Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tests for SetFieldIndex&GetFieldIndex #1044

Merged
merged 2 commits into from Jul 10, 2022
Merged

fix: add tests for SetFieldIndex&GetFieldIndex #1044

merged 2 commits into from Jul 10, 2022

Conversation

JalinWang
Copy link
Member

@JalinWang JalinWang changed the title opt: add tests for SetFieldIndex&GetFieldIndex fix: add tests for SetFieldIndex&GetFieldIndex Jul 1, 2022
@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@hsluoyz
Copy link
Member

hsluoyz commented Jul 1, 2022

@tangyang9464 plz review

@hsluoyz
Copy link
Member

hsluoyz commented Jul 1, 2022

@JalinWang fix:

image

@JalinWang
Copy link
Member Author

@JalinWang fix:

image

done

tangyang9464
tangyang9464 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@tangyang9464 tangyang9464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tangyang9464
Copy link
Member

@JalinWang Please add the appropriate documentation for this. When users use RBAC or priority-related APIs, the default Index they should follow or how to customize FieldIndex

@JalinWang
Copy link
Member Author

@JalinWang Please add the appropriate documentation for this. When users use RBAC or priority-related APIs, the default Index they should follow or how to customize FieldIndex

ok

@JalinWang
Copy link
Member Author

JalinWang commented Jul 1, 2022 •
edited

During the document composition, I add the additional test case for the customized priority token.

image

This was referenced Jul 1, 2022
Closed
Merged
@tangyang9464
Copy link
Member

During the document composition, I add the additional test case for the customized priority token.

image

It's ok.

@JalinWang
Copy link
Member Author

@hsluoyz Is there anything more to do on this PR?

@hsluoyz hsluoyz merged commit cfc60ff into casbin:master Jul 10, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.50.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangyang9464 tangyang9464 tangyang9464 approved these changes

@kilosonc kilosonc Awaiting requested review from kilosonc

@sagilio sagilio Awaiting requested review from sagilio

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]DeleteRole do not totally work in priority model
4 participants
@JalinWang @casbin-bot @hsluoyz @tangyang9464