Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add an error return for updatePolicies() #1043

Merged
merged 2 commits into from Jul 7, 2022
Merged

fix: add an error return for updatePolicies() #1043

merged 2 commits into from Jul 7, 2022

Conversation

imp2002
Copy link
Member

@imp2002 imp2002 commented Jun 30, 2022

Fix: #1039

@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@imp2002
Copy link
Member Author

imp2002 commented Jun 30, 2022 •
edited

Failed to pass CI. What happend? It's CI error?
image

@tangyang9464
Copy link
Member

Failed to pass CI. What happend? It's CI error?
image

unit test fail

@imp2002
Copy link
Member Author

imp2002 commented Jun 30, 2022 •
edited

image
why fmt undefined? It has been import.

It's ok on my local machine.
image

@hsluoyz
Copy link
Member

hsluoyz commented Jun 30, 2022

@tangyang9464 plz help investigate

tangyang9464
tangyang9464 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@tangyang9464 tangyang9464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz hsluoyz merged commit f0c2a4f into casbin:master Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

🎉 This PR is included in version 2.50.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangyang9464 tangyang9464 tangyang9464 approved these changes

@kilosonc kilosonc Awaiting requested review from kilosonc

@sagilio sagilio Awaiting requested review from sagilio

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Using less newPolicies to update oldPolices will cause a panic
4 participants
@imp2002 @casbin-bot @tangyang9464 @hsluoyz