-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: caching the govaluate expressions #1031
Conversation
@tangyang9464 @closetool @sagilio please review |
@timconinx Please make sure, that the PR title and commit messages follow the Conventional Commits spec Otherwise it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I recently did some work in this corner of the codebase and noticed something this change. I’m not a maintainer or anything, so please don’t read this as a binding request.
🎉 This PR is included in version 2.60.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Trying to provide a solution for issue #1028
All tests pass, but I'm not quite sure if every edge case is covered
Fix: #1028