fix: UpdateFilteredPolicies returns the oldPolicy containing ptype #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…containing ptype Signed-off-by: tangyang9464 <tangyang9464@163.com>
|
@closetool @sagilio please review |
|
@tangyang9464 can we add a test for this? |
@hsluoyz This requires the support of third-party adapter, because |
|
@hsluoyz In fact, the adapter instead of casbin should be modified for this problem, but because there are many adapters, I choose to modify casbin to be compatible |
|
@tangyang9464 ok, let's keep it this way first |
|
🎉 This PR is included in version 2.46.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tangyang9464 tangyang9464@163.com
fix: xorm-adapter#49